Re: Will PQregisterThreadLock() be documented?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Volkan YAZICI <volkan(dot)yazici(at)gmail(dot)com>, pgsql-docs(at)postgresql(dot)org
Subject: Re: Will PQregisterThreadLock() be documented?
Date: 2005-10-16 17:15:45
Message-ID: 200510161715.j9GHFjq22193@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Volkan YAZICI wrote:
> >> Will PQregisterThreadLock() - which is defined globally in
> >> src/interfaces/libpq/fe-connect.c - be documented?
>
> > Yes, it should be documented.
>
> Really? Do we intend applications to call it?

Uh, well, we never call it ourselves, so if we don't expect other
applications to call it, why is it there?

Our code has:

/*
* Used to set callback that prevents concurrent access to
* non-thread safe functions that libpq needs.
* The default implementation uses a libpq internal mutex.
* Only required for multithreaded apps that use kerberos
* both within their app and for postgresql connections.
*/
typedef void (*pgthreadlock_t) (int acquire);

extern pgthreadlock_t PQregisterThreadLock(pgthreadlock_t newhandler);

We need to research why it was added.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2005-10-16 17:52:29 Re: Will PQregisterThreadLock() be documented?
Previous Message Tom Lane 2005-10-16 16:47:44 Re: Will PQregisterThreadLock() be documented?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-10-16 17:38:53 Re: [HACKERS] Patching dblink.c to avoid warning about open transaction
Previous Message Tom Lane 2005-10-16 16:47:44 Re: Will PQregisterThreadLock() be documented?