From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] roundoff problem in time datatype |
Date: | 2005-10-14 11:48:20 |
Message-ID: | 200510141148.j9EBmKu24143@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Patch applied, with documentation updates.
---------------------------------------------------------------------------
Tom Lane wrote:
> Inserting into a time field with limited precision rounds off, which
> is good except for this case:
>
> regression=# select '23:59:59.9'::time(0);
> time
> ----------
> 24:00:00
> (1 row)
>
> This is bad because:
>
> regression=# select '24:00:00'::time(0);
> ERROR: date/time field value out of range: "24:00:00"
>
> which means that data originally accepted will fail to dump and reload.
>
> I see this behavior in all versions back to 7.3. 7.2 was even more
> broken:
>
> regression=# select '23:59:59.9'::time(0);
> time
> ----------
> 00:00:00
> (1 row)
>
> I think the correct behavior has to be to check for overflow again
> after rounding off. Alternatively: why are we forbidding the value
> 24:00:00 anyway? Is there a reason not to allow the hours field
> to exceed 23?
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 5.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-10-14 11:52:21 | Re: [PATCHES] [BUGS] BUG #1962: ECPG and VARCHAR |
Previous Message | Bruce Momjian | 2005-10-14 11:40:27 | Re: Allowed timezone values |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-10-14 11:52:21 | Re: [PATCHES] [BUGS] BUG #1962: ECPG and VARCHAR |
Previous Message | Dennis Vshivkov | 2005-10-14 06:29:11 | Bug#333854: pg_group file update problems |