Re: beta2 no longer builds with MSVC?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: beta2 no longer builds with MSVC?
Date: 2005-10-13 23:29:07
Message-ID: 200510132329.j9DNT7w26090@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> Has anybody tried building beta2 or later with MSVC? It doesn'?t work
> for me - it builds fine, but whenever I run with it I get a coredump
> from it whenever I try to connect.
>
> If I revert it to the 8.0 version of port/getaddrinfo.c, things work
> again.
>
> The problem shows itself in that conn->addr_cur->ai_addr is NULL when
> it reaches the "CONNECTION_NEEDED" branch in PQconnectPoll().
>
>
> Compiling with MingW appears to work fine.

Strange. Would you try this patch and see if it helps? It disables the
lookups to call the Win32-native getaddrinfo routines.

(I know you are busy so maybe someone else can test MSVC.)

Another posssible fix would be to do a 'continue' in the loop if
conn->addr_cur->ai_addr is NULL, and see if that works.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 546 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Creager 2005-10-14 00:12:43 Seeing context switch storm with 10/13 snapshot of 8.1beta3
Previous Message Bruce Momjian 2005-10-13 22:59:40 Re: [COMMITTERS] pgsql: Back out this because of fear of changing