Re: roundoff problem in time datatype

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: roundoff problem in time datatype
Date: 2005-10-13 20:53:55
Message-ID: 200510132053.j9DKrtc16848@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Where are we on this?
>
> We haven't decided what to do.
>
> I think my preference is to allow '24:00:00' (but not anything larger)
> as a valid input value of the time datatypes. This for two reasons:
> * existing dump files may contain such values
> * it's consistent with allowing, eg, '12:13:60', which we
> allow even though it's certainly not a valid leap second.
>
> The alternative is to try to catch all places where 23:59:59.something
> could get rounded up to 24:00:00, but that looks messy, and it would
> introduce a gotcha into calculations on time values.

Is this a must-fix for 8.1?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-10-13 21:00:33 Re: Questions about proper newline handling in psql output
Previous Message Tom Lane 2005-10-13 20:53:16 Re: roundoff problem in time datatype

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-10-13 20:58:42 Re: high values for client_min_messages
Previous Message Tom Lane 2005-10-13 20:53:16 Re: roundoff problem in time datatype