pgsql: Remove the DELETEs from pg_shadow and pg_group that pg_dumpall

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove the DELETEs from pg_shadow and pg_group that pg_dumpall
Date: 2005-10-10 22:29:49
Message-ID: 20051010222949.8FA89D9EF1@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove the DELETEs from pg_shadow and pg_group that pg_dumpall used to
emit when given the --clean option, in favor of individual DROP ROLE
commands. The old technique could not possibly work in 8.1, and was
never a very good idea anyway IMHO. The DROP ROLE approach has the
defect that the DROPs will fail for roles that own objects or have
privileges, but perhaps we can improve that later.

Modified Files:
--------------
pgsql/doc/src/sgml/ref:
pg_dumpall.sgml (r1.52 -> r1.53)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/pg_dumpall.sgml.diff?r1=1.52&r2=1.53)
pgsql/src/bin/pg_dump:
pg_dumpall.c (r1.67 -> r1.68)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c.diff?r1=1.67&r2=1.68)

Browse pgsql-committers by date

  From Date Subject
Next Message User Uniware 2005-10-11 01:35:50 vcproject - vcproject: New Directory
Previous Message Tom Lane 2005-10-10 20:02:21 pgsql: Use a safer order of operations in dropdb(): rollbackable