Re: [HACKERS] Patching dblink.c to avoid warning about open

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>
Subject: Re: [HACKERS] Patching dblink.c to avoid warning about open
Date: 2005-10-08 15:30:02
Message-ID: 200510081530.j98FU2224986@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Joe Conway wrote:
> Bruce Momjian wrote:
> > There was also a problem in that if two cursors were opened, the first
> > close would close the transaction. I have fixed that code by changing
> > the xact variable in to a counter that keeps track of the number of
> > opened cursors and commits only when they are all closed.
> >
> > Both the dblink.c patch and the regression patch are at:
> >
> > ftp://candle.pha.pa.us/pub/postgresql/mypatches
> >
>
> OK, I'll take a look, but I won't have time for a couple of days (I'm
> not at home -- visiting my dad for his 80th birthday -- and have no
> broadband access).

No problem -- thanks. I have slimmed down the patch by applying the
cosmetic parts to CVS. Use the URL above to get the newest versions of
the dblink.c and regression changes.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Martijn van Oosterhout 2005-10-08 15:48:56 [PATCH] Using pread instead of lseek (with analysis)
Previous Message Magnus Hagander 2005-10-08 15:09:36 Re: [HACKERS] Kerberos brokenness and oops question in 8.1beta2