| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Joe Conway <mail(at)joeconway(dot)com>, David Fetter <david(at)fetter(dot)org>, Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Patching dblink.c to avoid warning about open |
| Date: | 2005-10-07 16:05:16 |
| Message-ID: | 200510071605.j97G5Gj06255@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > The problem with not using rconn is that we are not saving the
> > transaction status at the _start_ of the cursor open. If we don't do
> > that, we have no way of knowing on close if _we_ opened the transaction
> > or whether it was opened by the user.
>
> Oh, I see. In that case the flag is horribly misnamed and miscommented.
> Something like "newXactForCursor" would be clearer.
OK, renamed to isClientXact.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-10-07 16:06:41 | Re: Vote needed: revert beta2 changes or not? |
| Previous Message | Tom Lane | 2005-10-07 15:59:53 | Re: [HACKERS] Patching dblink.c to avoid warning about open transaction |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-10-07 21:18:46 | Re: [BUGS] BUG #1927: incorrect timestamp returned |
| Previous Message | Tom Lane | 2005-10-07 15:59:53 | Re: [HACKERS] Patching dblink.c to avoid warning about open transaction |