Re: small changes to autovacuum maintainance

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: small changes to autovacuum maintainance
Date: 2005-09-23 02:07:10
Message-ID: 200509230207.j8N27A219373@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Robert Treat wrote:
> Attached patch takes a swing at improving the autovacuum wording in
> maintenance.sgml.

Thanks, applied.

> On a related note I was thinking to add a note in the runtime config section
> for autovacuum_enabled that stats_start_collector and stats_row_level must be
> on for enabled to work, would that still go in runtime.sgml ?

Yes, that is config.sgml now. Added.

> On a related note to that, I am wondering if it might be better to have the
> postmaster issue a fatal error on startup if autovacuum is on and stats are
> off, rather than the warning it does now. ISTM it is very easy to miss that
> warning (since it is only sent to stderr and not stout afaict) and looking in
> pg_settings there would be no indication that anything was wrong, other than
> autovacuum being set to off (perhaps if it was set to 'error, stats disabled'
> or some such it might be better?)

I don't think we usually fail on startup unless there is a major
problem. When people modify postgresql.conf, they better check the
server log file after startup.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-09-23 02:24:54 Re: SQL/XML publishing function experimental patch
Previous Message Bruce Momjian 2005-09-23 01:54:31 Re: [HACKERS] statement logging / extended query protocol issues