Re: [HACKERS] statement_timeout logging

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-documentation <pgsql-docs(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] statement_timeout logging
Date: 2005-09-17 04:31:16
Message-ID: 200509170431.j8H4VGP19475@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

Simon Riggs wrote:
> >Alvaro Herrera
> > On Fri, Sep 16, 2005 at 03:41:11PM -0400, Bruce Momjian wrote:
> > > > I have updated the message to:
> > > >
> > > > errmsg("canceling query due to user request or
> > statement timeout")));
> > >
> > > Oops. Did we freeze the message strings already for this release?
> >
> > Not yet.
> >
> > I'm not sure I agree with the wording though -- is there no
> > way to tell
> > the difference?
>
> Yes, my patch. :-)
>
> The message is generated following receipt of a SIGINT which is sent by
> kill() after the statement_timeout.
>
> My patch was able to generate a different message by logging just before
> the kill() is called. (Obviously, there isn't much "after" in this
> circumstance).

Your patch just prints a statement "before" printing the cancel message.
What we should do is to print the proper cause of the cancel, and I am
working on a patch for that.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Simon Riggs 2005-09-17 07:02:23 Re: [HACKERS] statement_timeout logging
Previous Message Alvaro Herrera 2005-09-16 20:54:55 Re: [HACKERS] statement_timeout logging

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-09-17 04:31:41 Re: Spinlocks, yet again: analysis and proposed patches
Previous Message Bruce Momjian 2005-09-17 04:22:11 BEOS code