Re: psql SET/RESET/SHOW tab completion

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am wondering if is worth managing which items should be displayed or
> > not, and if we should just give up and display them all. The GUC system
> > is just too dynamic.
>
> Not sure. I count 98 GUC variables currently listed in tab-complete.c,
> and 162 rows in pg_settings. So listing them all would be a pretty
> sizable increase (65%) in what's already an unwieldy list. I would
> prefer to see some thought given to removing useless entries ... eg,
> I doubt anyone needs tab completion for "trace_notify" or "wal_debug".
>
> However, if you favor a "no thought required" approach, listing 'em
> all is certainly the path of least resistance. I'm just dubious that
> that maximizes the usefulness of tab completion.

Can't we just pull these from pg_settings, with relivant restrictions on
what we list.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073