| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Determining return type of polymorphic function |
| Date: | 2005-08-12 12:53:37 |
| Message-ID: | 20050812125335.GE4305@svana.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Forgot to attach it, oops.
On Fri, Aug 12, 2005 at 09:56:47AM +0200, Martijn van Oosterhout wrote:
> Ok, here's a patch (with documentation update). I checked the
> regression tests (looked over, not run) but nothing there appears to
> test this anyway. I looked through all the datatype input functions but
> none of them even use the second argument except array and record types
> and they're explicitly unchanged.
>
> Note: the logic could be simplified if we could assume composite types
> can't have a non-zero typelem. From looking at the code, I think it may
> be assumed in places and I'm fairly sure it's non-sensical, but is it
> explicitly forbidden?
>
> I thought of writing a few simple tests but no language will accept
> cstring arguments except C. It can be added if you think it's worth
> regression testing.
>
> Unless there are other comments I'll post this to pgsql-patches
> later...
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
| Attachment | Content-Type | Size |
|---|---|---|
| typelem.patch | text/plain | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruno Wolff III | 2005-08-12 13:55:09 | Re: CREATE USER and pg_user |
| Previous Message | Alvaro Herrera | 2005-08-12 12:45:39 | Re: obtaining row locking information |