Re: Bug in canonicalize_path()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: William ZHANG <uniware(at)zedware(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Bug in canonicalize_path()
Date: 2005-08-12 03:15:25
Message-ID: 200508120315.j7C3FPu14988@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > But what about "usr/local/../../.."?
>
> What about it? The case of /usr/local/../../.. is handled correctly,
> and the case where it's an underspecified relative path doesn't seem
> that interesting to me --- certainly that is not so important that we
> should get the wrong answer on cases that *are* plausible.
>
> Most of the uses of canonicalize_path are on paths that are required to
> be absolute, anyway.
>
> It wouldn't be too implausible to error out if pending_strips>0 after
> exiting the loop.

I figured it would be best to leave it alone if we can't process it, but
if you think it is more imporant to trim in cases like ../.., go ahead.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message William ZHANG 2005-08-12 03:25:46 Re: Bug in canonicalize_path()
Previous Message Tom Lane 2005-08-12 03:14:08 Re: Bug in canonicalize_path()