pgsql: Adjust psql describe queries so that any pg_foo_is_visible()

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Adjust psql describe queries so that any pg_foo_is_visible()
Date: 2005-07-18 17:40:15
Message-ID: 20050718174015.2D59E52B39@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Adjust psql describe queries so that any pg_foo_is_visible() condition
is applied last, after other constraints such as name patterns. This
is useful first because the pg_foo_is_visible() functions are relatively
expensive, and second because it minimizes the prospects for race
conditions. The change is fragile though since it makes unwarranted
assumptions about planner behavior, ie, that WHERE clauses will be
executed in the original order if there's not reason to change it.
This should fix ... or at least hide ... an intermittent failure in the
prepared_xacts regression test, while we think about what else to do.

Modified Files:
--------------
pgsql/src/bin/psql:
describe.c (r1.120 -> r1.121)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c.diff?r1=1.120&r2=1.121)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-07-18 17:48:30 pgsql: Fix bogus backslash sequences, per Kris Jurka.
Previous Message Tom Lane 2005-07-18 17:17:12 pgsql: pgcrypto documentation update.