pgsql: Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)'

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)'
Date: 2005-07-15 17:09:50
Message-ID: 20050715170950.9DE0652D0F@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)' and related
cases: we can't just consider whether the subquery's output is unique on its
own terms, we have to check whether the set of output columns we are going to
use will be unique. Per complaint from Luca Pireddu and test case from
Michael Fuhr.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
pgsql/src/backend/optimizer/util:
pathnode.c (r1.111 -> r1.111.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/pathnode.c.diff?r1=1.111&r2=1.111.4.1)
pgsql/src/test/regress/expected:
subselect.out (r1.10.4.2 -> r1.10.4.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/subselect.out.diff?r1=1.10.4.2&r2=1.10.4.3)
pgsql/src/test/regress/sql:
subselect.sql (r1.7 -> r1.7.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/subselect.sql.diff?r1=1.7&r2=1.7.4.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-07-15 18:40:03 pgsql: Check for out-of-range varoattno in deparse_context_for_subplan.
Previous Message Tom Lane 2005-07-15 17:09:27 pgsql: Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)'