Re: Python setof patch

From: Michael Fuhr <mike(at)fuhr(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Gerrit van Dyk <gvandyk(at)agileworks(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Python setof patch
Date: 2005-07-05 14:00:52
Message-ID: 20050705140052.GB91794@winnie.fuhr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, Jul 04, 2005 at 03:04:51PM -0400, Bruce Momjian wrote:
>
> Patch applied. Thanks.
>
> Gerrit van Dyk wrote:
> >
> > This patch allows the PL/Python module to do (SRF) functions.

Does this patch work? The test_setof() function in sql/plpython_setof.sql
gives me the following:

SELECT * FROM test_setof();
test_setof
------------
1
(1 row)

If I call the function again I get this:

SELECT * FROM test_setof();
test_setof
------------
2
(1 row)

Calling the function a third time gives this:

SELECT * FROM test_setof();
test_setof
------------
(0 rows)

Am I misreading the code, or shouldn't the function return two rows
on each invocation?

I don't see the setof functionality in the regression tests,
presumably because there's no expected/plpython_setof.sql file:

============== running regression test queries ==============
test plpython_schema ... ok
test plpython_populate ... ok
test plpython_function ... ok
test plpython_test ... ok
test plpython_error ... ok
test plpython_drop ... ok

=====================
All 6 tests passed.
=====================

What about documentation updates? Still in the works?

--
Michael Fuhr
http://www.fuhr.org/~mfuhr/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Fuhr 2005-07-05 14:19:50 pgcrypto volatility and strictness changes
Previous Message jtv 2005-07-05 13:05:43 Error handling fix in interfaces/libpq/fe-secure.c