Re: [HACKERS] HEAD doesn't cope with libraries in non-default

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] HEAD doesn't cope with libraries in non-default
Date: 2005-07-04 04:15:50
Message-ID: 200507040415.j644FoY16458@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> It appears that somebody has changed things so that the -L switches
> >> appear after the -l switches (ie, too late). I'm too tired to
> >> investigate now, but my money is on Autoconf 2.59 being the problem ...
>
> > I wonder if it was this commit. I am attaching the patch so you can
> > test to see if it fixes it. If it does, please let us know.
>
> > ! SHLIB_LINK := $(filter -L%, $(LDFLAGS)) $(SHLIB_LINK)
> > ...
> > ! SHLIB_LINK := $(SHLIB_LINK) $(filter -L%, $(LDFLAGS))
>
> Urgh. This was considered a good idea why exactly?

I didn't like it myself but it fixed a problem with a build farm
machine, and no one objected, so I applied it, but it seemed pretty
strange to be reversing those. I will reverse the patch.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-07-04 04:16:12 Re: Constraint Exclusion (Partitioning) - Initial Review
Previous Message Oliver Jowett 2005-07-04 04:14:51 Re: HEAD doesn't cope with libraries in non-default locations

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-07-04 04:16:12 Re: Constraint Exclusion (Partitioning) - Initial Review
Previous Message Oliver Jowett 2005-07-04 04:14:51 Re: HEAD doesn't cope with libraries in non-default locations