Re: #ifdef NOT_USED

From: Abhijit Menon-Sen <ams(at)oryx(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: systemguards(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: #ifdef NOT_USED
Date: 2005-06-28 07:24:25
Message-ID: 20050628072425.GA25909@penne.toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(Sorry for the delayed response. I just got home from Germany after my
visit to Linuxtag, and I'm catching up with my -hackers email now.)

At 2005-06-25 09:30:17 -0400, pgman(at)candle(dot)pha(dot)pa(dot)us wrote:
>
> > Hi, i have found several #ifdef NOT_USED marked code...
>
> We keep such blocks of code around in case we might need to use it
> some day.

I think that's a bad idea. Unused code should be removed with a suitable
CVS checkin comment (and perhaps a comment where the code was), not left
to clutter live code. That's what version control is for.

-- ams

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2005-06-28 07:39:41 Re: For review: dbsize patch
Previous Message Teodor Sigaev 2005-06-28 07:22:38 Re: contrib/rtree_gist into core system?