Re: Server instrumentation patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: Michael Paesold <mpaesold(at)gmx(dot)at>, Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Server instrumentation patch
Date: 2005-06-24 19:08:14
Message-ID: 200506241908.j5OJ8EZ18549@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Michael Paesold [mailto:mpaesold(at)gmx(dot)at]
> > Sent: 24 June 2005 17:53
> > To: Dave Page; Andreas Pflug
> > Cc: PostgreSQL-development
> > Subject: Re: [HACKERS] Server instrumentation patch
> >
> > > My main concern is that the names are inconsistent for no obvious
> > > reason.
> >
> > That could be fixed by having:
> > pg_database_size(name)
> > pg_database_size(oid)
> >
> > The original idea was probably to name "internal" functions
> > with pg_ and
> > more user friendly ones without pg_. That does not mean it's
> > a good idea.
>
> Yes, agreed - it could be fixed that way easily. If the inclusion of
> /all/ functions is for backwards compatibility though, then that change
> is somewhat more of a problem.

We are moving the functions into the backend so if we are going to make
them more consistent, now is the time. People are already going to not
have to load them from /contrib, so a more consistent API change is fine
at this stage --- it will be much harder later.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2005-06-24 19:30:01 DBSize backend integration
Previous Message Dave Page 2005-06-24 18:59:31 Re: Server instrumentation patch