From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: code cleanup for tz |
Date: | 2005-06-21 03:20:00 |
Message-ID: | 200506210320.j5L3K0x16323@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > Tom Lane wrote:
> >> I think mostly what you are doing here is causing code drift from the
> >> upstream "zic" code. I don't think that's a very good idea, since we
> >> do need to be able to track and apply bug fixes from them from time
> >> to time ...
>
> > Why run pgindent on the timezone code, then? That seems guaranteed to
> > cause a lot more merge headaches...
>
> Well, it's certainly hopeless to expect "patch" to fix it :-(. But the
> further the code drifts the harder it gets to compare manually.
>
> This isn't an academic concern; I went through it once already, and I
> expect we'll want to do it again every release cycle when we sync the
> zic database with upstream.
I think the idea is that we will pgindent the new release of the
timezone code and then diff that against our current CVS.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Kirkwood | 2005-06-21 04:44:36 | Re: TODO Item - Return compressed length of TOAST datatypes |
Previous Message | Neil Conway | 2005-06-21 02:09:42 | pg_restore: fix bogosity |