Re: [PATCHES] Escape handling in strings

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pg(at)rbt(dot)ca, pgsql-hackers(at)postgresql(dot)org, chriskl(at)familyhealth(dot)com(dot)au
Subject: Re: [PATCHES] Escape handling in strings
Date: 2005-06-17 01:53:45
Message-ID: 200506170153.j5H1rkV19482@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
> Bruce Momjian said:
>
> > OK, the current patch warns about two things, \' with one message, and
> > any backslash in a non-E string with a different message. The \'
> > message can easily be avoided in clients even in 8.0 by using '', but
> > for E'', there is no way to prepare an application before upgrading to
> > 8.1 because 8.0 doesn't have E''. (We can add E'' in a subrelease, but
> > what percentage of users are going to upgrade to that?) This is why I
> > think we need to add a GUC to allow the warning to be turned off. To
> > be clear, the GUC is to control the warning, not the query behavior.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > We could go with the second warning only in 8.2, but that seems too
> > confusing --- we should deal with the escape issue in two stages,
> > rather than three.
> >
>
> So you don't agree with Tom's suggestion to implement E'' a full cycle
> before removing backslash processing in standard strings? Or have I
> misunderstood again?

I think you misunderstood. There is no scheduled date to change the
actual behavior. The issue is whether we delay one release before
issuing a warning for backslashes in non-E strings.

I have highlighted the sentence where I say we are talking about when to
add the warning, not when to change the behavior.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Qingqing Zhou 2005-06-17 02:12:06 Re: Autovacuum in the backend
Previous Message Bruce Momjian 2005-06-17 01:41:05 Re: [PATCHES] Escape handling in strings

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-06-17 03:33:54 Re: [PATCHES] Escape handling in strings
Previous Message Bruce Momjian 2005-06-17 01:41:05 Re: [PATCHES] Escape handling in strings