Re: patches for OS/2 port

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: lsunley(at)mb(dot)sympatico(dot)ca, pgsql-patches(at)postgresql(dot)org
Subject: Re: patches for OS/2 port
Date: 2005-06-06 19:32:49
Message-ID: 200506061932.j56JWnA09563@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> lsunley(at)mb(dot)sympatico(dot)ca writes:
> > The attached zip file (os2port.zip) contains an os2.diff file that has all
> > the patches for the os/2 port and a file os2newfiles.zip file that has the
> > additional files required for the port.
> > [ 130k diff snipped ]
>
> We were willing to tolerate a port this invasive for Windows, but it's
> real hard to justify adding so much cruft for OS/2.

I agree with Tom on this. The patch is 4k context diff, and the new
files are 30k. It just seems too large for a port we are unlikely going
to be able to test or maintain. I think it is like the Netware port
where we rely out port-specific folks to maintain a patch. We can
mention the patch URL in the FAQ, and already have an OS/2 link there.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2005-06-06 20:09:55 indxpath.c refactoring
Previous Message Pavel Stehule 2005-06-06 19:28:35 SQLSTATE and SQLERRM