| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Server instrumentation: pg_terminate_backend, pg_reload_conf |
| Date: | 2005-06-06 16:07:18 |
| Message-ID: | 200506061607.j56G7IZ19504@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Andreas Pflug wrote:
> Bruce Momjian wrote:
> > Andreas Pflug wrote:
> >
> >>This patch reenables pg_terminate_backend, allowing (superuser only, of
> >>course) to terminate a backend. As taken from the discussion some weeks
> >>earlier, SIGTERM seems to be used quite widely, without a report of
> >>misbehavior so while the code path is officially not too well tested,
> >>in practice it's working ok and helpful.
> >
> >
> > I thought we had a discussion that the places we accept SIGTERM might be
> > places that can exit if the postmaster is shutting down, but might not
> > be places we can exit if the postmaster continues running, e.g. holding
> > locks. Have you checked all the places we honor SIGTERM to check that
> > we are safe to exit? I know Tom had concerns about that.
>
> My patch is purely to enable a supervisor to issue a SIGTERM using a
> pgsql client, instead of doing it from a server command line. It's not
> meant to fix the underlying problems.
We don't support sending SIGTERM from the server command line to
individual backends, so why add support for it in SQL?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-06-06 16:08:56 | Re: pg_starttime() |
| Previous Message | Bruce Momjian | 2005-06-06 16:02:18 | Re: regexp_replace |