From: | momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Back out patch: |
Date: | 2005-06-04 22:57:22 |
Message-ID: | 20050604225722.60CFD52913@svr1.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Back out patch:
---------------------------------------------------------------------------
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> a_ogawa <a_ogawa(at)hi-ho(dot)ne(dot)jp> writes:
> > It is a reasonable idea. However, the majority part of MemSet was not
> > able to be avoided by this idea. Because the per-tuple contexts are used
> > at the early stage of executor.
>
> Drat. Well, what about changing that? We could introduce additional
> contexts or change the startup behavior so that the ones that are
> frequently reset don't have any data in them unless you are working
> with pass-by-ref values inside the inner loop.
That might be possible. However, I think that we should change only
aset.c about this article.
I thought further: We can check whether context was used from the last
reset even when blocks list is not empty. Please see attached patch.
Modified Files:
--------------
pgsql/src/backend/utils/mmgr:
aset.c (r1.61 -> r1.62)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mmgr/aset.c.diff?r1=1.61&r2=1.62)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-06-04 23:06:29 | pgsql: Add pg_dump to TODO.detail. |
Previous Message | Bruce Momjian | 2005-06-04 20:56:14 | pgsql: Add comment for multi-byte computation. |