Re: Refactoring in lock.c

On Wed, May 18, 2005 at 12:33:51PM +1000, Neil Conway wrote:
> Alvaro Herrera wrote:
> >Additionally, I found that no callers of LockReleaseAll and LockRelease
> >had any use for their return values, so I made them return void.
>
> Is there a reason we can't just elog(ERROR) rather than returning?

I thought about that too. I'm not sure why the original code would
continue chugging along if the lock table is not consistent. Maybe it
was because back in the Berkeley days this code would step on bugs with
some regularity. I wonder if we could get away with changing it now.

Anyway, I didn't want to propose such a thing because a change in
functionality is not what I want to do in a refactor patch -- if the
idea is shot down, the whole thing is shot down and the patch is not
applied.

--
Alvaro Herrera (<alvherre[a]surnet.cl>)
Tulio: oh, para qué servirá este boton, Juan Carlos?
Policarpo: No, aléjense, no toquen la consola!
Juan Carlos: Lo apretaré una y otra vez.