From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCHES] Cleaning up unreferenced table files |
Date: | 2005-05-10 20:55:45 |
Message-ID: | 200505102055.j4AKtj522003@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Heikki Linnakangas wrote:
> On Sun, 8 May 2005, Tom Lane wrote:
>
> > While your original patch is buggy, it's at least fixable and has
> > localized, limited impact. I don't think these schemes are safe
> > at all --- they put a great deal more weight on the semantics of
> > the filesystem than I care to do.
>
> I'm going to try this some more, because I feel that a scheme like this
> that doesn't rely on scanning pg_class and the file system would in fact
> be safer.
The current code is nice and localized and doesn't add any burden on our
existing code, which is already complicated enough. I think we either
fix checkfiles.c, or we remove it and decide it isn't worth checking for
unrefrenced files.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Cramer | 2005-05-10 20:57:01 | Re: Can we get patents? |
Previous Message | Heikki Linnakangas | 2005-05-10 20:29:22 | Re: [PATCHES] Cleaning up unreferenced table files |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-05-10 21:03:30 | Re: [PATCHES] Cleaning up unreferenced table files |
Previous Message | Heikki Linnakangas | 2005-05-10 20:29:22 | Re: [PATCHES] Cleaning up unreferenced table files |