Re: BUG #1545: LIBPQ Windows Version not calling WSACleanup for

Tom Lane wrote:
> "Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> >> Actually ... why do we need a WSAStartup in makeEmptyPGconn?
> >> If we have one in DLL attach, isn't that sufficient?
>
> > Not if you link libpq as a static lib...
>
> > I *think* that's why it was added. In the beginning it was only in the
> > DLL attach code, and if you were using the library as a static lib you
> > had to call it yourself. Not sure when that changed, but clearly that is
> > when the WSACleanup() call should've gone in.
>
> Ah. Makes sense. So adding it to freePGconn is correct.
>
> Bruce, you should probably back-patch for as far as the WSAStartup call
> is there, which looks to be 7.4.

OK, going ahead. I am not thrilled to be fixing this so close to the
release for untestable code.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073