Re: Problem with Create Domain example

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Problem with Create Domain example
Date: 2005-05-01 02:08:32
Message-ID: 200504302208.32599.xzilla@users.sourceforge.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Saturday 30 April 2005 21:14, Alvaro Herrera wrote:
> On Sat, Apr 30, 2005 at 06:12:27PM -0400, Robert Treat wrote:
> > --- 167,174 ----
> > <programlisting>
> > CREATE DOMAIN us_postal_code AS TEXT
> > CHECK(
> > ! VALUE ~ '^\\d{5}$'
> > ! OR VALUE ~ '^\\d{5}-\\d{4}$'
> > );
>
> Huh, why not
>
> VALUE ~ '^\\d{5}(-\\d{4})?$'
>
> ?

Not sure what your driving at here... my point is that the \ escaping is
incorrect in the current examples.

If you want to argue that we could make the check constraint simpler (or is
that more advanced) that seems like another issue. IMHO having the OR'd
checks is better because it shows that you can "stack" constraints inside a
domain if you want.

--
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2005-05-01 02:45:29 Re: Problem with Create Domain example
Previous Message Alvaro Herrera 2005-05-01 01:14:59 Re: Problem with Create Domain example