Re: pg_restore -F bug

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_restore -F bug
Date: 2005-04-29 13:34:25
Message-ID: 200504291334.j3TDYPd20735@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway wrote:
> This patch fixes a bug in the error message emitted by pg_restore on an
> incorrect -F argument: write_msg() expects its first parameter to be a
> "module name", not the format string. Patch applied to HEAD. Is this
> worth backporting?
>
> BTW, is there a reason that pg_restore seems to accept 'f', 't', or 'c'
> parameters to this argument, but the documentation only documents 't'
> and 'c'?

I didn't think pg_restore could use a text file, and I think it emits an
error if you try. Maybe they accept the flag so they can throw a
meaningful error later.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-04-29 13:59:33 Re: [INTERFACES] bcc32 libpq compile problem
Previous Message f.guidi@libero.it 2005-04-29 12:37:19 Re: [INTERFACES] bcc32 libpq compile problem