Re: Faster install-sh in C

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Faster install-sh in C
Date: 2005-03-23 20:23:15
Message-ID: 200503232023.j2NKNFT05186@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> > Also, keep in my that this C install program has the extra feature of
> > being able to install multiple files on one invocation, per suggestion
> > from Tom Lane. This allows us to save the nested for-loop in
> > src/include/Makefile. GNU install (available on my system) also has
> > this capability, but would we be able to use the trick if we had to
> > cater for the lowest common denominator found on other, non-GNU-enabled
> > systems?
>
> We would definitely not ... and my suspicion is that that is the largest
> single component of the available speedup.

OK, what is 'install' doing for us that 'cp' and 'chmod' would not
already do? The following patch reduces the 'gmake install' in
/src/include from 8 seconds to 0.8 seconds.

Oh, and for testing I use a sourceforge shell farm account, and a HP
testdrive shell acount that gives me access to almost every operating
system.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 952 bytes

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-03-23 20:29:28 Re: Faster install-sh in C
Previous Message Tom Lane 2005-03-23 17:48:29 Re: Faster install-sh in C