Re: snprintf improvements

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: snprintf improvements
Date: 2005-03-02 23:57:55
Message-ID: 200503022357.j22Nvt327502@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This patch uses our own snprintf() only when NLS support is enabled,
>
> I see no point in this; it does not solve any problem we need solved,
> only complicate the configuration behavior even more.

Peter answered this.

> > I added support for %qd and %I64d in snprintf.
>
> I consider this an awful idea as well.

Moved into a NOT_USED block so we can keep it in case we want it later.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-03-03 00:03:02 Re: [pgsql-hackers-win32] snprintf causes regression tests
Previous Message pgsql 2005-03-02 21:38:28 Re: [pgsql-hackers-win32] snprintf causes regression