From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Use _() macro consistently rather than gettext(). |
Date: | 2005-02-22 18:16:08 |
Message-ID: | 200502221816.j1MIG8Q09655@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-patches |
Thanks. Fixed. I wasn't aware the the macro namespace didn't
distinguish X(a) and X(a,b) as different macros, so I was undefining
_(x).
---------------------------------------------------------------------------
Neil Conway wrote:
> Bruce Momjian wrote:
> > Use _() macro consistently rather than gettext(). Add translation
> > macros around strings that were missing them.
>
> This commit induces the following warnings:
>
> In file included from /home/neilc/pgsql/src/timezone/localtime.c:20:
> /home/neilc/pgsql/src/timezone/private.h:107:9: warning: extra tokens at
> end of #undef directive
> In file included from /home/neilc/pgsql/src/timezone/strftime.c:27:
> /home/neilc/pgsql/src/timezone/private.h:107:9: warning: extra tokens at
> end of #undef directive
> In file included from /home/neilc/pgsql/src/timezone/zic.c:18:
> /home/neilc/pgsql/src/timezone/private.h:107:9: warning: extra tokens at
> end of #undef directive
> In file included from /home/neilc/pgsql/src/timezone/ialloc.c:11:
> /home/neilc/pgsql/src/timezone/private.h:107:9: warning: extra tokens at
> end of #undef directive
> In file included from /home/neilc/pgsql/src/timezone/scheck.c:11:
> /home/neilc/pgsql/src/timezone/private.h:107:9: warning: extra tokens at
> end of #undef directive
>
> -Neil
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-02-22 19:06:24 | pgsql: Document that only a table's owner may TRUNCATE it. |
Previous Message | User Dpage | 2005-02-22 10:14:40 | pginstaller - pginst: Require cube to be selected before earthdistance |
From | Date | Subject | |
---|---|---|---|
Next Message | Kurt Roeckx | 2005-02-22 18:57:15 | Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c |
Previous Message | Neil Conway | 2005-02-22 10:28:01 | Re: WIP: pl/pgsql cleanup |