Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory
Date: 2005-02-15 04:08:18
Message-ID: 200502150408.j1F48IQ13644@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


This has been saved for the 8.1 release:

http://momjian.postgresql.org/cgi-bin/pgpatches2

---------------------------------------------------------------------------

ITAGAKI Takahiro wrote:
> Hello everyone.
>
> I fixed two bugs in the patch that I sent before.
> Check and test new one, please.
>
> 1. Fix update timing of Write->curridx. (pointed by Tom)
> Change to update it soon after write().
>
> 2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
> I checked it on Xeon EM64T and it worked properly, but I don't have IA64...
>
>
> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
> (But this leak is not serious, because this function is called only once.)
>
>
> ITAGAKI Takahiro

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2005-02-15 04:10:36 Re: enforcing a plan (in brief)
Previous Message Bruce Momjian 2005-02-15 04:05:43 Re: unicode upper/lower functions

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-02-15 04:33:37 Re: Which release cycle are we in?
Previous Message Bruce Momjian 2005-02-15 03:09:55 Re: Shared dependency patch