Re: Errno checks for rmtree()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Errno checks for rmtree()
Date: 2005-02-13 01:28:02
Message-ID: 200502130128.j1D1S2D28353@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, so you just wanted _an_ error string to be printed on failure rather
> > than the reasons.
>
> Well, what we want to know is the particular file that couldn't be
> deleted and the errno code. This is all "can't happen" stuff and so
> it just has to be a message that is useful for debugging; I don't see
> that it has to be amazingly user-friendly.

Wow, you want to print out the raw errno number. We only do that in one
or two places in our code that I could fine.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-02-13 01:40:53 Re: Errno checks for rmtree()
Previous Message Tom Lane 2005-02-13 01:26:05 Re: Errno checks for rmtree()