Re: [BUGS] "pg_ctl -w" does not return a failure exit code when postmaster

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Steve McWilliams <smcwilliams(at)EmprisaNetworks(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] "pg_ctl -w" does not return a failure exit code when postmaster
Date: 2004-12-21 17:38:55
Message-ID: 200412211738.iBLHctP04500@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Steve McWilliams wrote:
> I have noticed on linux that if you try to start postmaster via "pg_ctl
> -w", but the postmaster fails to run (e.g. if you forgot to create
> PGDATA), it returns a 0 exit code. It needs to return a non-0 exit code
> if postmaster failed to start, when you are using the "-w" option to wait
> for it to start.

OK, this small applied patch fixes the problem. pg_ctl.c is a new file
in 8.0 so we didn't hit all the return values correctly on our first
try.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 591 bytes

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2004-12-21 17:56:59 Re: [BUGS] Problems with "-w" option on pg_ctl.exe running as a windows
Previous Message j6m 2004-12-21 17:30:49 Polymorphism resgression test fails when BLCKSZ changed

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-12-21 17:56:59 Re: [BUGS] Problems with "-w" option on pg_ctl.exe running as a windows
Previous Message Steve McWilliams 2004-12-21 16:43:06 Problems with "-w" option on pg_ctl.exe running as a windows service