Re: WIN1252 encoding - backend or not?

Tom Lane wrote:
> "Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> > But further down we have:
> > #define PG_ENCODING_BE_LAST PG_WIN1250
>
> Scarier than that is grepping the source code for -i win125, and noting
> the number of places that cover the existing WIN125[016] encodings but
> fail to mention WIN1252. In particular I notice that pg_wchar_table[]
> in wchar.c has no entry added for WIN1252, which means that this patch
> broke every encoding with higher code numbers.
>
> Bruce, I think this patch has to come out. We should not be in the
> business of debugging a new feature post-RC1.

OK, patch backed out and all added files removed. I will save the idea
for 8.1.

As far as the patch itself, I don't think I ever claimed it was ready
for prime time --- rather, I followed process and it was applied. If
Tom saying "it isn't ready for prime time" meant "back it out", I didn't
read it that way. Of course anyone can ask for an applied patch to be
backed out, as per procedure, and it is easily done.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073