Re: Fix for "q" with psql display paging dumps out of psql

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> jseymour(at)linxnet(dot)com (Jim Seymour) writes:
> > I'm kind of wondering if anybody on the dev team noticed this and
> > what, if anything, they planned to do with it?
>
> Can we make it "#ifdef SOLARIS7" somehow? I'm uneager to put a
> performance penalty on every platform because of an admittedly
> broken signal implementation on one.

I don't have a problem with #ifdef'ing it in/out. But will an extra
pqsignal() call at that point would incur an appreciable performance
penalty?

>
> Also, you didn't explain what changed between 7.4.2 and 7.4.6 to
> make this necessary when it wasn't before.

That would involve extensive slogging though the code, identifying all
the changes made between 7.4.2 and who-knows-what-version (the problem
exists with 7.4.5, as well) and working-out their impact.

Yeah, it's a kludgy fix. I certainly won't be offended if you don't
care to address this problem--particularly if you don't care to use
that fix.

Jim