Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path

Is Cygwin now working properly in CVS and beta5? I assume so.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> > >>beta4 - cygwin:
> > >>postgres.exe fails to build, because __imp__my_exec_path from
> > >>src/timezone/pgtz.o cannot be resolved. previously it was not
> > >>imported.
> > >
> > > This could be related to the patch that went in last weekend to fix
> > > compiles on Win32. DLLIMPORT was added to the header. If
> > the Makefile
> > > did not change, then that is your problem - that patch
> > changed botht
> > > he makefile and the header. See
> > > http://archives.postgresql.org/pgsql-committers/2004-10/msg00321.php
> > >
> > > Does CYGWIN perhaps need the same Makefile patch?
> >
> > You only patched your Makefile.win32, not Makefile.cygwin.
> > That's it. It builds fine now.
> >
> > Please add also
> >
> > ifneq (,$(findstring timezone,$(subdir))) override CPPFLAGS+=
> > -DBUILDING_DLL endif
> >
> > to the Makefile.cygwin.
> > Without it doesn't break just contrib/tsearch, it even breaks
> > cygwin postmaster.
>
> Soudns reasonable.
>
>
> > Maybe all win32.mak and bcc32.mak must also be checked. Does
> > anybody do the msvc/borland suites?
>
> Not affected. Only the frontend can be compiled with those, and this is
> a backend change.
>
> //Magnus
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073