From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, josh(at)agliodbs(dot)com, jd(at)commandprompt(dot)com, plperlng-devel(at)pgfoundry(dot)org |
Subject: | Re: [Plperlng-devel] Re: Concern about new PL/Perl |
Date: | 2004-11-19 18:56:42 |
Message-ID: | 20041119185641.GD14815@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 19, 2004 at 05:29:20AM -0600, Andrew Dunstan wrote:
> Tom Lane said:
> > Josh Berkus <josh(at)agliodbs(dot)com> writes:
> >>> I would agree that seems a little odd ;). Would this be something we
> >>> want done for 8.0?
> >
> >> I think we'd better. Otherwise, people will get used to the broken
> >> syntax.
> >
> > Agreed. Someone's going to step up and patch this, no?
> >
> > (Not me --- I've already wasted more hours than I could afford this
> > week on plperl.)
> >
>
> I knew I should have looked at this closer when Peter made his complaint -
> it sounded familiar. IIRC it was actually a point I raised about the
> original code, and it was fixed. At any rate, last night Abhijit Menon-Sen
> and I looked at the code and got confused becuse it appears to have been
> fixed ;-). "rows" only contains data and only exists if the result is from a
> successful select. "processed" is the row count, and is always present.
>
> So it's a case of bad documentation, which we will fix very shortly. Sorry
> for the noise.
Please find attached a patch that fixes this.
Cheers,
D
--
David Fetter david(at)fetter(dot)org http://fetter.org/
phone: +1 510 893 6100 mobile: +1 415 235 3778
Remember to vote!
Attachment | Content-Type | Size |
---|---|---|
plperl.diff | text/plain | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Pflug | 2004-11-19 19:00:50 | Re: Test database for new installs? |
Previous Message | Tom Lane | 2004-11-19 18:55:33 | Re: OpenBSD/Sparc status |