Re: Win32 psql fix

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 psql fix
Date: 2004-10-18 17:57:40
Message-ID: 200410181757.i9IHve312516@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > The attached patch fixes psql's win32 frontend-only build, by using
> > pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
> > miscadmin.h.
>
> What in the world is client-side code doing including miscadmin.h
> in the first place?

Ah, it is getting included from the port files. Let me see if I can fix
that with FRONTEND tests.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-10-18 18:16:49 Final libpq patch?
Previous Message Peter Eisentraut 2004-10-18 17:57:00 Re: Updated Turkish translations