Re: Slightly better testing for pg_ctl(1)'s -w...

Patch applied. Thanks.

I simplified your test and made the error message a #define that is now
used consistently in all places. Patch attached.

---------------------------------------------------------------------------

Sean Chittenden wrote:
> pg_ctl(1)'s -w option works well if the default user can automatically
> authenticate without any user intervention. The attached patch checks
> the error message to see if it's asking for a password. The theory
> being that if it's asking for a password, the backend is up. I'm not
> entirely happy with the fact that I'm dependent on the error message
> text, but I couldn't easily figure out a better way to test this via
> libpq(3), so I'm not too unhappy... it's just not elegant. This patch
> does not encompass all possible scenarios for the backend being up, but
> CONNECTION_BAD being set in libpq(3). Regardless, it's a start and
> hopefully someone can apply this. I also cleaned up a small memory
> leak when a connection is bad (PGconn not being free(3)'ed). -sc
>
> % pg_ctl -w start && psql
> waiting for postmaster to start....done
> postmaster started
> test=>
>

[ Attachment, skipping... ]

>
>
> --
> Sean Chittenden
>

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073