Re: pgindent complaint of the day

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent complaint of the day
Date: 2004-10-07 03:02:28
Message-ID: 200410070302.i9732SL00572@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > and this does exactly as you describe by putting the comment on its own
> > line. I just changed it to:
> > ...
> > so that the new comment will have the same indenting as the else that
> > was input.
>
> If it were "the else's indent plus one more tab" it would be reasonably
> sane; it'd match the indentation of what comes next.

OK, I can do that but consider:

else /* comment */
{
something;
}

If we go without the special indent we get at worst case:

else
/* comment */
something;

while with an extra indent we get this as worst case:

else
/* comment */
{
something;
}

which seems like a worse worst case. :-)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-07 03:19:21 Re: pgindent complaint of the day
Previous Message Tom Lane 2004-10-07 02:59:15 Re: pgindent complaint of the day