Re: [PATCHES] That dump-comments-on-composite-type-columns

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] That dump-comments-on-composite-type-columns
Date: 2004-10-06 17:43:07
Message-ID: 200410061743.i96Hh7C03049@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Christopher Kings-Lynne wrote:
> > Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > > OK, I can do this, but I don't think I'll have time for the first beta.
> >
> > No problem.
>
> Another interesting think I noticed in pg_dump is dumping of LOBs. It
> seems to declare a cursor that fetches the blobs and then issues a fetch
> 1000 to get the first 1000 lobs. It never seems to execute any further
> fetches. Am I right that if you have more than 1000 lobs in postgres,
> pg_dump won't dump them?

I checked and though the Fetch string is issued outside the loop, it
keeps getting used inside the loop.

There was some strange capitalization that confused things and I cleaned
that up.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruno Wolff III 2004-10-06 17:48:16 Re: database constraints
Previous Message Bruce Momjian 2004-10-06 17:37:33 Re: SRF/dropped column bug

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-10-06 17:45:56 Re: CREATE DATABASE with tablespace fix
Previous Message Bruce Momjian 2004-10-06 17:23:29 Re: pg_dumpall bug in PG 8.0b3 Win32 port