From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | "Magnus Hagander" <mha(at)sollentuna(dot)net>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: plpython win32 |
Date: | 2004-09-24 21:20:19 |
Message-ID: | 200409242320.19373.peter_e@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Magnus Hagander wrote:
> This patch attempts to fix the build of plpython on win32. Needs
> autoconf of course - don't have mine working on win32, so that part
> hasn't been 100% tested. My tests involved #:ing out all the code
> that would be included by that rule, and that makes it work, so I
> think we're safe....
Please do not use PORTNAME in external macros. I like to think that one
can take these macros and put them in some other project without
requiring the prior setup that the PostgreSQL configure.in does.
Instead, use AC_REQUIRE([AC_CANONICAL_HOST]) and resolve the issue
using $host_os.
Also, add some comments to the magic you add in the makefiles.
The hardcoded Python version number will of course not stand the test of
time.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2004-09-24 21:22:52 | Re: plpython win32 |
Previous Message | Serguei A. Mokhov | 2004-09-24 21:15:38 | Translation updates for 8.0: libpq-ru, pg_controldata-ru |