Re: 8.0.0beta2: gcc: unrecognized option `-pthreads'

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >>> No. The problem is that the test script just tries all options and if
> >>> it doesn't error out, it uses it. Ideally we could test from configure
> >>> and ingnore meaningless options but we don't know how yet.
> >>
> >> Drop any options that cause the compiler to write anything on stderr.
>
> > OK, the configure test is:
>
> BTW, I had some second thoughts about this later: if the compiler
> generates warnings only for certain *combinations* of switches, it
> seems likely that a simplistic test would get things wrong. Let's
> try this patch, but be alert for possible problems.

Ah, but we test the accumulation of flags, not just each flag in
isolation:

LIBS="$tryPTHREAD_LIBS $PTHREAD_LIBS $LIBS"
CFLAGS="$CFLAGS $PTHREAD_CFLAGS $tryPTHREAD_CFLAGS"

so we should be fine.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073