Re: pgsql 8.0.0b1 - openssl detection

From: Stefanos Harhalakis <v13(at)it(dot)teithe(dot)gr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: pgsql 8.0.0b1 - openssl detection
Date: 2004-08-20 15:26:21
Message-ID: 200408201826.27663.v13@it.teithe.gr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Friday 20 August 2004 03:52, Tom Lane wrote:
> Stefanos Harhalakis <v13(at)it(dot)teithe(dot)gr> writes:
> > It seems that the problem is in src/template/linux:
> >
> > $ cat src/template/linux=20
> > # Force _GNU_SOURCE on; plperl is broken with Perl 5.8.0 otherwise
> > CPPFLAGS="-D_GNU_SOURCE"
> >
> > which is beeing sourced by configure.in. Changing this to
> > CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
> > solves the problem.
>
> Hmm, good point (and I see template/hpux is committing the same sin).
>
> For CFLAGS, configure.in takes pains to not let the template file
> override a user-supplied setting. Should we do the same for CPPFLAGS,
> or just apply the quick-and-dirty patch suggested by Stefanos to these
> two templates?

I believe that if someone shall have to set CPPFLAGS="-I..." for openssl then
he should not have to guess that CPPFLAGS should also contain -D_GNU_SOURCE,
unless it is stated in the documentation or as a warning when running the
configure script.

<<V13>>

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2004-08-20 15:44:28 Re: 8.0.0beta1 small inconsistency in pg_aggregate listing
Previous Message Bruce Momjian 2004-08-20 15:13:27 Re: BUG #1225: stat failed on file '$libdir/utf8_and_euc_jp'