Re: 8.0 libpq: missing get_home_path()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 8.0 libpq: missing get_home_path()
Date: 2004-08-18 18:35:20
Message-ID: 200408181835.i7IIZLG06081@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I need to call canonicalize_path() in the macro.
>
> There is only one use of get_home_path in libpq. Lose it and do
> a direct getenv(HOMEDIR). You do not really need to do a
> canonicalize_path there; it'd be sufficient to insert the appropriate
> directory separator ('/' or '\') when forming pgpassfile just below.

OK, sounds like a plan. I will add a comment about its purpose.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-08-18 18:38:06 Re: initdb failure on win32
Previous Message Marc G. Fournier 2004-08-18 17:52:03 Re: stop the presses (Re: 7.4.4 packaged ...)

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2004-08-18 19:31:53 Re: Compiling libpq with VC6
Previous Message Tom Lane 2004-08-18 17:27:10 Re: 8.0 libpq: missing get_home_path()