Re: [COMMITTERS] pgsql-server: PostgreSQL extension makefile framework

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server: PostgreSQL extension makefile framework
Date: 2004-08-11 16:55:01
Message-ID: 200408111855.01814.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Am Dienstag, 10. August 2004 17:55 schrieb Fabien COELHO:
> (1) all makefiles in contrib include directly "src/Makefile.global" which
> is generated by configure, although it is already included by the
> "src/makefiles/pgxs.mk" makefile anyway, so it seems to me that it
> is useless because redundant?

No, because you need Makefile.global to define top_srcdir, which is needed to
find pgxs.mk. You changed all top_srcdir to top_builddir, which is wrong.

> (2) only static includes are used, so I cannot use "pg_config --pgxs"
> approach to install a contrib against an already compiled postgresql?
> basically, you drop the USE_PGXS stuff for dynamic configuration
> of contrib makefiles, and I have found no replacement.

I don't see the point of that. If you have a PostgreSQL source tree, you can
install the contribs right there. How else would you do it?

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2004-08-11 17:20:51 pgsql-server: Work around broken strtod() that's present in many Solaris
Previous Message Tom Lane 2004-08-11 16:53:36 pgsql-server: Fix function definition that somehow missed being

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2004-08-11 17:05:10 Re: libpq problem
Previous Message Fabien COELHO 2004-08-11 16:33:00 Re: pg_dump 'die_on_errors'