From: | momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql-server: I have noticed that the latex format in psql has some |
Date: | 2004-08-06 18:09:18 |
Message-ID: | 20040806180918.E9D8F5E46D8@svr1.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
I have noticed that the latex format in psql has some bugs:
o "_" is not escaped, and causes TeX to abort, thinking it's a
subscript outside of maths mode. Most of my table and field names
use underscores, so this is a really nasty one.
o The column count is calculated using the contents of opt_align. But
opt_align has one extra element, and so it's always one too many. I
changed it to count the column headings, like all the other output
formats. There may be a bug in computing opt_align that this patch
does not address, but I'm not yet familiar enough with the psql
source to fix this as well.
o The line drawing rules for each border setting (0-3) and expanded
mode didn't always match the documented behaviour and what other
formats (e.g. aligned) did. I made it as conformant as possible,
and also tidied the alignment of the first line of the footer, which
was incorrectly indented.
Roger Leigh
Modified Files:
--------------
pgsql-server/src/bin/psql:
print.c (r1.48 -> r1.49)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/psql/print.c.diff?r1=1.48&r2=1.49)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-08-06 18:18:43 | pgsql-server: Revert badly-broken patch to dump comments on |
Previous Message | Tom Lane | 2004-08-06 18:05:50 | pgsql-server: Use one, not zero, as the default lower bound for arrays |