Re: autovacuum integration attempt #3

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: autovacuum integration attempt #3
Date: 2004-07-21 20:18:12
Message-ID: 200407212018.i6LKID915666@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


I am having problem applying this. I don't think we can just move
pg_autovacuum.[ch] right into the backend code. There are issues with
include files and there is no definition for autovacuum_vacuum_base and
other variables, and there is no AutoVacMain(). I can try guessing on
those but I think I need a more complete patch or more complete
instructions to get this applied. Also, it uses the gcc-ism
__attribute__ that isn't portable to other compilers.

---------------------------------------------------------------------------

Matthew T. O'Connor wrote:
> Ok, here is a new patch for to integrate pg_autovacuum into the backend.
>
> This patch adds the following to that last patch:
> * updated to latest CVS
> * changed GUC vars from autovac_* to autovacuum_*
> * changed autovac_enabled GUC variable to autovacuum
> * changed autovacuum GUC variable default to false
> * improved autovacuum failure when row level stats aren't enabled
>
> As before, this patch requires pg_autovacuum.c and .h get moved
> from contrib to src/backend/postmaster and src/include/postmaster
> respectively. In addition, the attached pg_autovacuum.h file must be put
> in src/include/catelog/ for the new pg_autovacuum system
> table.
>
> Please apply to CVS or tell me what I need to change to get it applied.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-07-21 20:22:45 Re: Docs for PL/Perl
Previous Message Simon Riggs 2004-07-21 20:00:49 Re: [HACKERS] Point in Time Recovery