From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: serverlog rotation/functions |
Date: | 2004-07-14 14:50:03 |
Message-ID: | 200407141450.i6EEo3R08412@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
We could make the same adjustments when opening a new log file rather
than pipe, no?
---------------------------------------------------------------------------
Tom Lane wrote:
> I wrote:
> > close(2);
> > d = dup(p[0]);
> > Assert(d == 2);
>
> Having re-read the pipe(2) man page, of course that should be
> d = dup(p[1]);
> since it's the writing end of the pipe you want to plug stderr into.
>
> BTW, if it wasn't clear: I'd do the same pushup for stdout too,
> just in case. I'm not sure there is any output to stdout left in the
> backend, but I wouldn't swear there is not, either.
>
> regards, tom lane
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-07-14 14:50:55 | Re: PITR Archive Recovery plus WIP PITR |
Previous Message | Christopher Kings-Lynne | 2004-07-14 14:48:00 | Better fixes for pg_dump bugs |